Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update python dependencies #16105

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Update python dependencies #16105

merged 1 commit into from
Sep 9, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Sep 6, 2019

Description

Update dependencies to match pip release

@lanking520 @access2rohit

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk requested a review from szha as a code owner September 6, 2019 02:02
@access2rohit
Copy link
Contributor

@zachgk can you retrigger the CI

@zachgk zachgk merged commit 9675a2d into apache:master Sep 9, 2019
@aaronmarkham
Copy link
Contributor

Wouldn't this imply that CI's python install scripts need to be updated accordingly?

@zachgk
Copy link
Contributor Author

zachgk commented Sep 10, 2019

@aaronmarkham That would make sense. I did a search to find other places to update (including the CI install scripts) for #16137.

larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants